Re: wake up logical workers after ALTER SUBSCRIPTION

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: wake up logical workers after ALTER SUBSCRIPTION
Date: 2022-12-02 00:21:30
Message-ID: 20221202002130.GA2124877@nathanxps13
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Tue, Nov 29, 2022 at 09:04:41PM -0800, Nathan Bossart wrote:
> I don't mind fixing it! There are a couple more I'd like to track down
> before posting another revision.

Okay, here is a new version of the patch. This seems to clear up
everything that I could find via the tests.

Thanks to this effort, I discovered that we need to include
wal_retrieve_retry_interval in our wait time calculations after failed
tablesyncs (for the suppress-unnecessary-wakeups patch). I'll make that
change and post that patch in a new thread.

Nathan Bossart
Amazon Web Services:

Attachment Content-Type Size
v4-0001-wake-up-logical-workers-after-ALTER-SUBSCRIPTION-.patch text/x-diff 6.2 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2022-12-02 00:40:42 Re: Avoid LWLockWaitForVar() for currently held WAL insertion lock in WaitXLogInsertionsToFinish()
Previous Message Andres Freund 2022-12-02 00:13:21 Re: HOT chain validation in verify_heapam()