Re: pgsql: Prevent instability in contrib/pageinspect's regression test.

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Prevent instability in contrib/pageinspect's regression test.
Date: 2022-11-21 17:22:06
Message-ID: 20221121172206.h6kywxrzqcmhoqom@awork3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Hi,

On 2022-11-21 15:51:05 +0000, Tom Lane wrote:
> Prevent instability in contrib/pageinspect's regression test.
>
> pageinspect has occasionally failed on slow buildfarm members,
> with symptoms indicating that the expected effects of VACUUM
> FREEZE didn't happen. This is presumably because a background
> transaction such as auto-analyze was holding back global xmin.
>
> We can work around that by using a temp table in the test.
> Since commit a7212be8b, that will use an up-to-date cutoff xmin
> regardless of other processes. And pageinspect itself shouldn't
> really care whether the table is temp.
>
> Back-patch to v14. There would be no point in older branches
> without back-patching a7212be8b, which seems like more trouble
> than the problem is worth.

Looks like a chunk of the buildfarm doesn't like this - presumably because
they use force_parallel_mode = regress. Seems ok to just force that to off in
this test?

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2022-11-21 17:24:17 Re: pgsql: Prevent instability in contrib/pageinspect's regression test.
Previous Message Tom Lane 2022-11-21 16:59:35 pgsql: Provide options for postmaster to kill child processes with SIGA

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-11-21 17:24:17 Re: pgsql: Prevent instability in contrib/pageinspect's regression test.
Previous Message Alvaro Herrera 2022-11-21 17:12:54 Re: Catalog_xmin is not advanced when a logical slot is lost