Re: pg_ls_tmpdir to show directories and shared filesets (and pg_ls_*)

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, David Steele <david(at)pgmasters(dot)net>
Subject: Re: pg_ls_tmpdir to show directories and shared filesets (and pg_ls_*)
Date: 2022-10-28 00:38:15
Message-ID: 20221028003815.GG16921@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Dec 13, 2019 at 03:03:47PM +1300, Thomas Munro wrote:
> > Actually, I tried using pg_ls_tmpdir(), but it unconditionally masks
> > non-regular files and thus shared filesets. Maybe that's worth
> > discussion on a new thread ?
> >
> > src/backend/utils/adt/genfile.c
> > /* Ignore anything but regular files */
> > if (!S_ISREG(attrib.st_mode))
> > continue;
>
> +1, that's worth fixing.

@cfbot: rebased on eddc128be.

Attachment Content-Type Size
v37-0001-Document-historic-behavior-of-links-to-directori.patch text/x-diff 1.0 KB
v37-0002-Add-tests-before-changing-pg_ls_.patch text/x-diff 3.4 KB
v37-0003-Add-pg_ls_dir_metadata-to-list-a-dir-with-file-m.patch text/x-diff 17.8 KB
v37-0004-pg_ls_tmpdir-to-show-directories-and-isdir-argum.patch text/x-diff 6.6 KB
v37-0005-pg_ls_-dir-to-show-directories-and-isdir-column.patch text/x-diff 13.3 KB
v37-0006-pg_ls_logdir-to-ignore-error-if-initial-top-dir-.patch text/x-diff 3.1 KB
v37-0007-pg_ls_-dir-to-return-all-the-metadata-from-pg_st.patch text/x-diff 21.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2022-10-28 00:38:50 Re: Support logical replication of DDLs
Previous Message Zheng Li 2022-10-28 00:20:42 Re: Support logical replication of DDLs