While reviewinghttps://postgr.es/m/CAD21AoBe2o2D%3Dxyycsxw2bQOD%3DzPj7ETuJ5VYGN%3DdpoTiCMRJQ%40mail.gmail.comI noticed that pg_recvlogical prints"pg_recvlogical: error: unexpected termination of replication stream: "
when signalled with SIGINT/TERM.
Oddly enough, that looks to have "always" been the case, even though clearlythe code tried to make provisions for a different outcome.
It looks to me like all that's needed is to gate the block printing themessage with an !time_to_abort.
I also then noticed that we don't fsync the output file in cases of errors -that seems wrong to me? Looks to me like that block should be moved till afterthe error:?