Re: [Proposal] Add foreign-server health checks infrastructure

Hi,

On 2022-09-21 11:56:56 +0000, kuroda(dot)hayato(at)fujitsu(dot)com wrote:
> PSA rebased patches. I reviewed my myself and they contain changes.
> E.g., move GUC-related code to option.c.

This seems to reliably fail on windows. See
https://cirrus-ci.com/task/6454408568373248
https://cirrus-ci.com/github/postgresql-cfbot/postgresql/commitfest/39/3388

https://api.cirrus-ci.com/v1/artifact/task/6454408568373248/testrun/build/testrun/postgres_fdw/regress/regression.diffs

diff -w -U3 C:/cirrus/contrib/postgres_fdw/expected/postgres_fdw.out C:/cirrus/build/testrun/postgres_fdw/regress/results/postgres_fdw.out
--- C:/cirrus/contrib/postgres_fdw/expected/postgres_fdw.out 2022-10-02 14:47:24.486355800 +0000
+++ C:/cirrus/build/testrun/postgres_fdw/regress/results/postgres_fdw.out 2022-10-02 15:02:03.039752800 +0000
@@ -11478,6 +11478,8 @@
ALTER SERVER loopback OPTIONS (SET application_name 'healthcheck');
-- Set GUC for checking the health of remote servers
SET postgres_fdw.health_check_interval TO '1s';
+ERROR: invalid value for parameter "postgres_fdw.health_check_interval": 1000
+DETAIL: postgres_fdw.health_check_interval must be set to 0 on this platform
BEGIN;
SELECT 1 FROM ft1 LIMIT 1;
?column?
@@ -11495,7 +11497,15 @@

-- While sleeping the process down will be detected.
SELECT pg_sleep(3);
-ERROR: Foreign Server loopback might be down.
+ pg_sleep
+----------
+
+(1 row)
+
COMMIT;
+ERROR: server closed the connection unexpectedly
+ This probably means the server terminated abnormally
+ before or while processing the request.
+CONTEXT: remote SQL command: COMMIT TRANSACTION
-- Clean up
RESET debug_discard_caches;

Greetings,

Andres Freund