Re: [RFC] building postgres with meson - v13

Hi,

Attached is v13 of the meson patchset. The biggest changes are:

- fix for the occasional ecpg.c crashes - which turned out to be crashes of
python, which in turn likely are due to a bug in the windows CRT

- split out and improved the patch to add resource files on windows. This
doesn't yet add them to all binaries, but I think the infrastructure looks
better now, and there's no duplicated win32ver.rc anymore.

- several rebasing adjustments, most notably the parser stuff and the
introduction of postgresql-full.xml

- improved structure of docs, based on Peter's review (Samay)

- generation of proper dependencies for xmllint/xsltproc, by parsing xsltproc
--load-trace. Previously the meson build didn't rebuild docs properly (meson
doesn't have "glob-style" dependencies). (Bilal)

- numerous small improvements and fixes

- added a patch to drop DLLTOOL/DLLWRAP from configure.ac / Makefile.global.in
- we've removed the use of them in 2014. This way the pgxs emulation doesn't
need to care.

- noticed that libpgport.a had and needed a dependency on errcodes.h - that
seemed wrong. The dependency is due to src/port/*p{read,write}v?.c including
postgres.h - which seems wrong. So I added a patch changing them to include
c.h.

One thing I just realized is that the existing autoconf/make and
src/tools/msvc buildsystems don't generate static libraries for e.g. libpq. So
far the meson build generates both static and shared libraries on windows
too.

Meson solves the naming conflict that presumably lead to us not generating
static libraries on windows by naming the link library for dlls's differently
than static libraries.

I'm inclined to build the static lib on windows as long as we do it on other
platforms.

Greetings,

Andres Freund