| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, John Naylor <jcnaylor(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: optimize lookups in snapshot [sub]xip arrays |
| Date: | 2022-08-10 00:13:43 |
| Message-ID: | 20220810001343.GA1546507@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 09, 2022 at 01:00:37PM -0700, Nathan Bossart wrote:
> Your adjustments in 0002 seem reasonable to me. I think it makes sense to
> ensure there is test coverage for pg_lfind32(), but I don't know if that
> syscache code is the right choice. For non-USE_SSE2 builds, it might make
> these lookups more expensive. I'll look around to see if there are any
> other suitable candidates.
One option might be to create a small test module for pg_lfind32(). Here
is an example.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v12-0001-Introduce-optimized-routine-for-linear-searches-.patch | text/x-diff | 9.7 KB |
| v12-0002-Optimize-linear-searches-in-XidInMVCCSnapshot.patch | text/x-diff | 2.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-08-10 00:33:07 | Re: pg_get_constraintdef: Schema qualify foreign tables unless pretty printing is enabled |
| Previous Message | Lukas Fittl | 2022-08-10 00:10:35 | pg_get_constraintdef: Schema qualify foreign tables unless pretty printing is enabled |