Re: Cleaning up historical portability baggage

From: Andres Freund <andres(at)anarazel(dot)de>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Cleaning up historical portability baggage
Date: 2022-08-07 01:29:14
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


Here's another set patches for cruft I discovered going line-by-line through
the autoconf vs meson test differences. They'd all be simple to port to meson
too, but I think it's better to clean them up.

0001: __func__ is C99, so we don't need to support fallbacks

0002: windows: We've unconditionally defined HAVE_MINIDUMP_TYPE for msvc forever, we
can rely on it for mingw too

0003: aix: aix3.2.5, aix4.1 are not even of historical interest at this point
- 4.1 was released before the first commit in our commit history

0004: solaris: these gcc & gnu ld vs sun stuff differences seem unnecessary or

I started this because I wanted to get rid of with_gnu_ld, but there's still
a necessary reference left unfortunately. But it still seems worth doing?

I checked and the relevant options (-shared, -Wl,-Bsymbolic, -Wl,-soname)
work even on solaris 10 with developerstudio12.5 (not the latest)

0005: those broken system headers look to have been repaired a good while ago,
or, in the case of irix, we don't support the platform anymore


Andres Freund

Attachment Content-Type Size
0001-Rely-on-__func__-being-supported.patch text/x-diff 8.6 KB
0002-windows-Remove-HAVE_MINIDUMP_TYPE-test.patch text/x-diff 4.4 KB
0003-aix-Remove-checks-for-very-old-OS-versions.patch text/x-diff 2.1 KB
0004-solaris-Remove-unnecessary-gcc-gnu-ld-vs-sun-studio-.patch text/x-diff 1.8 KB
0005-Trust-a-few-system-headers-to-stand-on-their-own.patch text/x-diff 4.1 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Bharath Rupireddy 2022-08-07 01:39:34 Re: Use fadvise in wal replay
Previous Message Noah Misch 2022-08-07 01:26:00 Re: failing to build preproc.c on solaris with sun studio