Re: Cleaning up historical portability baggage

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Cleaning up historical portability baggage
Date: 2022-08-04 02:30:10
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


On 2022-08-03 21:52:04 -0400, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > Another potential cleanup is the fallback for strtoll/strtoull.
> +1, I suspect the alternate spellings are dead.

Looks like that includes systems where there's no declaration for strtoll,
strtoull. The test was introduced in

commit a6228128fc48c222953dfd41fd438522a184054c
Author: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Date: 2018-05-18 22:42:10 -0400

Arrange to supply declarations for strtoll/strtoull if needed.

The check was introduced for animal dromedary, afaics. Looks like that stopped
reporting 2019-09-27 and transformed into florican.

A query on the bf database didn't see any runs in the last 30 days that didn't
have strtoll declared.

See attached patch.


Andres Freund

Attachment Content-Type Size
v1-0001-Remove-fallbacks-for-strtoll-strtoull.patch text/x-diff 7.2 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2022-08-04 02:42:38 Re: [PATCH] postgresql.conf.sample comment alignment.
Previous Message Julien Rouhaud 2022-08-04 02:19:39 Re: [PATCH] postgresql.conf.sample comment alignment.