Re: Allow file inclusion in pg_hba and pg_ident files

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Aleksander Alekseev <aleksander(at)timescale(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Nathan Bossart <nathandbossart(at)gmail(dot)com>
Subject: Re: Allow file inclusion in pg_hba and pg_ident files
Date: 2022-07-26 05:04:02
Message-ID: 20220726050402.vsr6fmz7rsgpmdz3@jrouhaud
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


On Mon, Mar 28, 2022 at 04:22:32PM +0900, Michael Paquier wrote:
> On Mon, Mar 28, 2022 at 04:20:07PM +0900, Michael Paquier wrote:
> > See the attached, for reference, but it would fail with EXEC_BACKEND
> > on WIN32.
> Ditto.

While working on the full regression test coverage for the file inclusion
thing, I discovered an embarrassing typo in the pg_ident_file_mapping
infrastructure, which was using the hba file name rather than the ident file
name in one of the calls.

It doesn't have much impact most of the time. The filename is reported if
there's an IO error while reading the already opened correct file. The real
problem is if the hba_file and ident_file are stored in different directory,
any secondary file (@filename) in the pg_ident.conf would be searched in the
wrong directory. With the pending file inclusion patchset, the problem is
immediately visible as the view is reporting the wrong file name.

Simple fix attached. I'll add a v15 open item shortly.

Attachment Content-Type Size
v1-0001-Fix-fill_ident_view-incorrect-usage-of-HbaFileNam.patch text/plain 995 bytes

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2022-07-26 05:14:48 Re: Allow file inclusion in pg_hba and pg_ident files
Previous Message Amit Kapila 2022-07-26 05:01:15 Re: Introduce wait_for_subscription_sync for TAP tests