Re: minor change for create_list_bounds()

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: Zhihong Yu <zyu(at)yugabyte(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: minor change for create_list_bounds()
Date: 2022-07-13 18:30:08
Message-ID: 20220713183008.GA3117671@nathanxps13
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Wed, Jul 13, 2022 at 05:07:53PM +1200, David Rowley wrote:
> While I agree that the gains on making this change are small. It just
> accounts to saving a call to bms_add_member() when we've already found
> the partition to be interleaved due to interleaved Datum values, I
> just disagree with not doing anything about it. My reasons are:
> 1. This code is new to PG15. We have the opportunity now to make a
> meaningful improvement and backpatch it. When PG15 is out, the bar is
> set significantly higher for fixing this type of thing due to having
> to consider the additional cost of backpatching conflicts with other
> future fixes in that area.
> 2. I think the code as I just pushed it is easier to understand than
> what was there before.

Fair enough.

> 3. I'd like to encourage people to look at and critique our newly
> added code. Having a concern addressed seems like a good reward for
> the work.


Nathan Bossart
Amazon Web Services:

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2022-07-13 18:38:03 Re: Add --{no-,}bypassrls flags to createuser
Previous Message Tom Lane 2022-07-13 18:28:44 Re: make update-po@master stops at pg_upgrade