| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: should check interrupts in BuildRelationExtStatistics ? |
| Date: | 2022-06-17 22:25:49 |
| Message-ID: | 20220617222549.GI29853@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jun 06, 2022 at 04:23:34PM +0900, Michael Paquier wrote:
> On Sat, Jun 04, 2022 at 08:42:33PM -0500, Justin Pryzby wrote:
> > The fix seems to be to CHECK_FOR_INTERRUPTS() within multi_sort_compare().
> > That would supercede the other two CHECK_FOR_INTERRUPTS I'd proposed, and
> > handle mcv, depends, and ndistinct all at once.
>
> Hmm. I have to admit that adding a CFI() in multi_sort_compare()
> stresses me a bit as it is dependent on the number of rows involved,
> and it can be used as a qsort routine.
That's exactly the problem for which I showed a backtrace - it took 10s of
seconds to do qsort, which is (uh) a human timescale and too long to be
unresponsive, even if I create on a table with many rows a stats object with a
lot of columns and a high stats target.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-wip-check-for-interrupts-during-extended-stats.patch | text/x-diff | 950 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2022-06-17 22:30:46 | Re: Checking for missing heap/index files |
| Previous Message | Andres Freund | 2022-06-17 20:06:05 | Re: PG 15 (and to a smaller degree 14) regression due to ExprEvalStep size |