| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Avoid erroring out when unable to remove or parse logical rewrite files to save checkpoint work |
| Date: | 2022-02-15 23:11:23 |
| Message-ID: | 20220215231123.GA2584239@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Feb 15, 2022 at 10:37:58AM -0800, Nathan Bossart wrote:
> On Tue, Feb 15, 2022 at 10:10:34AM -0800, Andres Freund wrote:
>> I generally think it'd be a good exercise to go through an use
>> get_dirent_type() in nearly all ReadDir() style loops - it's a nice efficiency
>> win in general, and IIRC a particularly big one on windows.
>>
>> It'd probably be good to add a reference to get_dirent_type() to
>> ReadDir[Extended]()'s docs.
>
> Agreed. I might give this a try.
Alright, here is a new patch set where I've tried to replace as many
stat()/lstat() calls as possible with get_dirent_type(). 0002 and 0003 are
the same as v9. I noticed a few remaining stat()/lstat() calls that don't
appear to be doing proper error checking, but I haven't had a chance to try
fixing those yet.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v10-0001-make-more-use-of-get_dirent_type.patch | text/x-diff | 10.7 KB |
| v10-0002-add-error-checking-for-call-to-lstat-in-replicat.patch | text/x-diff | 1.1 KB |
| v10-0003-minor-improvements-to-replication-code.patch | text/x-diff | 1.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2022-02-15 23:17:25 | Re: do only critical work during single-user vacuum? |
| Previous Message | Magnus Hagander | 2022-02-15 22:37:07 | Re: Observability in Postgres |