Re: Add checkpoint and redo LSN to LogCheckpointEnd log message

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: masao(dot)fujii(at)oss(dot)nttdata(dot)com
Cc: bharath(dot)rupireddyforpostgres(at)gmail(dot)com, nathandbossart(at)gmail(dot)com, sfrost(at)snowman(dot)net, bossartn(at)amazon(dot)com, rjuju123(at)gmail(dot)com, michael(at)paquier(dot)xyz, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Add checkpoint and redo LSN to LogCheckpointEnd log message
Date: 2022-02-14 05:52:15
Message-ID: 20220214.145215.1633261010375598220.horikyota.ntt@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Mon, 14 Feb 2022 14:42:18 +0900 (JST), Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote in
> I'll resend new version soon to avoid the confusion..

In this version , 0001 gets one fix and two comment updates.

- * Archive recovery have ended. Crash recovery ever after should always
+ * Archive recovery has ended. Crash recovery ever after should always

- /* the second term is just in case */
- if (PriorRedoPtr != InvalidXLogRecPtr || RedoRecPtr > PriorRedoPtr)
+ /*
+ * Update the average distance between checkpoints/restartpoints if the
+ * prior checkpoint exists. The second term is just in case.
+ */
+ if (PriorRedoPtr != InvalidXLogRecPtr && RedoRecPtr > PriorRedoPtr)
UpdateCheckPointDistanceEstimate(RedoRecPtr - PriorRedoPtr);

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

Attachment Content-Type Size
v10-0001-Get-rid-of-unused-path-to-handle-concurrent-chec.patch text/x-patch 6.1 KB
v10-0002-Add-checkpoint-and-redo-LSN-to-LogCheckpointEnd-.patch text/x-patch 3.0 KB
v10-0003-Change-location-to-lsn-in-pg_controldata.patch text/x-patch 2.6 KB
v10-0004-Change-location-to-lsn-in-user-facing-text.patch text/x-patch 15.1 KB
v10-0005-Get-rid-of-uses-of-some-hyphenated-words.patch text/x-patch 4.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-02-14 06:18:48 sockaddr_un.sun_len vs. reality
Previous Message Kyotaro Horiguchi 2022-02-14 05:42:18 Re: Add checkpoint and redo LSN to LogCheckpointEnd log message