Re: standby recovery fails (tablespace related) (tentative patch and discussion)

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: rjuju123(at)gmail(dot)com
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: standby recovery fails (tablespace related) (tentative patch and discussion)
Date: 2022-01-20 06:07:22
Message-ID: 20220120.150722.1493024686617230588.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Sun, 16 Jan 2022 12:43:03 +0800, Julien Rouhaud <rjuju123(at)gmail(dot)com> wrote in
> Other than that, I see that the TAP tests are failing on all the environment,
> due to Perl errors. For instance:

Perl seems to have changed its behavior for undef hash.

It is said that "if (%undef_hash)" is false but actually it is true
and "keys %undef_hash" is 1.. Finally I had to make
backup_tablespaces() to return a hash reference. The test of
pg_basebackup takes a backup with tar mode, which broke the test
infrastructure. Cluster::backup now skips symlink adjustment when the
backup contains "/base.tar".

I gave up testing on Windows on my own environment and used Cirrus CI.

# However, it works for confirmation of a established code. TAT of CI
# is still long to do trial and error of unestablished code..

This version works for Unixen but still doesn't for Windows. I'm
searching for a fix for Windows.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

Attachment Content-Type Size
v15-0001-Add-tablespace-support-to-TAP-framework.patch text/x-patch 11.3 KB
v15-0002-Tests-to-replay-create-database-operation-on-sta.patch text/x-patch 6.0 KB
v15-0003-Fix-replay-of-create-database-records-on-standby.patch text/x-patch 10.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amul Sul 2022-01-20 06:43:08 Re: TAP test to cover "EndOfLogTLI != replayTLI" case
Previous Message Takashi Menjo 2022-01-20 05:55:13 Re: Map WAL segment files on PMEM as WAL buffers