Re: pgsql: Test replay of regression tests, attempt II.

Hi,

On 2022-01-17 16:02:34 +0900, Michael Paquier wrote:
> On Mon, Jan 17, 2022 at 03:35:48AM +0000, Thomas Munro wrote:
> > Test replay of regression tests, attempt II.
> >
> > See commit message for 123828a7fa563025d0ceee10cf1b2a253cd05319. The
> > only change this time is the order of the arguments passed to
> > pg_regress. The previously version broke in the build farm environment
> > due to the contents of EXTRA_REGRESS_OPTS (see also commit 8cade04c
> > which had to do something similar).
> >
> > Discussion: https://postgr.es/m/CA%2BhUKGKpRWQ9SxdxxDmTBCJoR0YnFpMBe7kyzY8SUQk%2BHeskxg%40mail.gmail.com
>
> Butterflyfish has just failed in this new test:
> https://buildfarm.postgresql.org/cgi-bin/show_history.pl?nm=butterflyfish&br=HEAD
>
> Ad the pg_regress command has failed one of the tests:
> reloptions ... FAILED 1377 ms
>
> No idea what's going on here, but I guess that we'd better show up the
> contents of regression.diffs in the TAP logs if it exists.

This also failed on CI, which collected the regression.diffs:
https://api.cirrus-ci.com/v1/artifact/task/6460573058596864/regress_diffs/src/test/recovery/regression.diffs
https://cirrus-ci.com/task/6460573058596864

diff -w -U3 c:/cirrus/src/test/recovery/../regress/expected/reloptions.out c:/cirrus/src/test/recovery/results/reloptions.out
--- c:/cirrus/src/test/recovery/../regress/expected/reloptions.out 2022-01-17 07:08:52.779337800 +0000
+++ c:/cirrus/src/test/recovery/results/reloptions.out 2022-01-17 07:24:46.785394900 +0000
@@ -133,7 +133,7 @@
SELECT pg_relation_size('reloptions_test') = 0;
?column?
----------
- t
+ f
(1 row)

and the server log:
https://api.cirrus-ci.com/v1/artifact/task/6460573058596864/log/src/test/recovery/tmp_check/log/027_stream_regress_primary.log

I'm not entirely clear on what the regression test is trying to test here.

It's plausible the standby was a bit behind at that point and prevented
VACUUM from truncating via hot_standby_feeback?

Greetings,

Andres Freund