Re: pgbench: using prepared BEGIN statement in a pipeline could cause an error

From: Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pgbench: using prepared BEGIN statement in a pipeline could cause an error
Date: 2021-11-15 17:26:43
Message-ID: 20211116022643.c9d0fc95fe4e520a97c37bcc@sraoss.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello Daniel Gustafsson,

On Mon, 15 Nov 2021 14:13:32 +0100
Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:

> > On 21 Jul 2021, at 03:49, Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp> wrote:
>
> > I attached the updated patch v2, which includes a comment fix and a TAP test.
>
> This patch fails the TAP test for pgbench:

Thank you for pointing it out!
I attached the updated patch.

Regards,
Yugo Nagata

> # Tests were run but no plan was declared and done_testing() was not seen.
> # Looks like your test exited with 25 just after 224.
> t/001_pgbench_with_server.pl ..
> Dubious, test returned 25 (wstat 6400, 0x1900)
> All 224 subtests passed
> t/002_pgbench_no_server.pl .... ok
> Test Summary Report
> -------------------
> t/001_pgbench_with_server.pl (Wstat: 6400 Tests: 224 Failed: 0)
> Non-zero exit status: 25
> Parse errors: No plan found in TAP output
> Files=2, Tests=426, 3 wallclock secs ( 0.04 usr 0.00 sys + 1.20 cusr 0.36 csys = 1.60 CPU)
> Result: FAIL
>
> --
> Daniel Gustafsson https://vmware.com/
>

--
Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>

Attachment Content-Type Size
v3-pgbench-prepare.patch text/x-diff 3.3 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-11-15 17:43:39 Re: Test::More version
Previous Message Tom Lane 2021-11-15 17:19:51 Re: Time to drop plpython2?