Re: Missing log message in recoveryStopsAfter() for RECOVERY_TARGET_TIME recovery target type

At Wed, 13 Oct 2021 19:56:17 +0530, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote in
> Hi,
>
> I see that the recoveryStopsAfter() doesn't have any "recovery
> stopping after XXXX" sort of log for RECOVERY_TARGET_TIME recovery
> target type. It has similar logs for other recoveryTarget types
> though. Is there any specific reason for not having it?
>
> I see that we have "starting point-in-time recovery to XXXX" sorts of
> logs for all the recovery target types and also recoveryStopsBefore()
> has a log (by setting stopsHere) for RECOVERY_TARGET_TIME.

So you should have seen the following comment there.
> /*
> * There can be many transactions that share the same commit time, so
> * we stop after the last one, if we are inclusive, or stop at the
> * first one if we are exclusive
> */

Since both inclusive and exclusive cases are processed in
recoveryStopsBefore(), recoveryStopsAfter() has nothing to do for the
target type.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center