|From:||Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>|
|To:||Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>|
|Cc:||Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, kuroda(dot)hayato(at)fujitsu(dot)com, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>|
|Subject:||Re: pgbench bug candidate: negative "initial connection time"|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
On Tue, 7 Sep 2021 02:34:17 +0900
Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
> On 2021/07/29 13:23, Yugo NAGATA wrote:
> > Hello,
> > On Fri, 18 Jun 2021 15:58:48 +0200 (CEST)
> > Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> wrote:
> >> Attached Yugo-san patch with some updates discussed in the previous mails,
> >> so as to move things along.
> > I attached the patch rebased to a change due to 856de3b39cf.
> + pg_log_fatal("connection for initialization failed");
> + pg_log_fatal("setup connection failed");
> + pg_log_fatal("cannot create connection for client %d",
> These fatal messages output when doConnect() fails should be a bit more consistent each other? For example,
> could not create connection for initialization
> could not create connection for setup
> could not create connection for client %d
Ok. I fixed as your suggestion.
> > Exit status 1 indicates static problems such as invalid command-line options.
> > Errors during the run such as database errors or problems in the script will
> > result in exit status 2.
> While reading the code and docs related to the patch, I found
> these descriptions in pgbench docs. The first description needs to be
> updated? Because even database error (e.g., failure of connection for setup)
> can result in exit status 1 if it happens before the benchmark actually runs.
That makes sense. Failures of setup connection or initial connection doesn't
seem 'static problems'. I rewrote this description to explain exit status 1
indicates also interal errors and early errors.
Exit status 1 indicates static problems such as invalid command-line options
or internal errors which are supposed to never occur. Early errors that occur
when starting benchmark such as initial connection failures also exit with
Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>
|Next Message||Jonathan S. Katz||2021-09-23 22:46:32||Re: PostgreSQL 14 press release draft|
|Previous Message||Daniel Gustafsson||2021-09-23 21:41:26||Re: OpenSSL 3.0.0 compatibility|