|From:||Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>|
|To:||Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>|
|Subject:||Re: Avoid stuck of pbgench due to skipped transactions|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
On Sun, 13 Jun 2021 08:56:59 +0200 (CEST)
Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> wrote:
> > I attached a patch for this fix.
> The patch mostly works for me, and I agree that the bench should not be in
> a loop on any parameters, even when "crazy" parameters are given…
> However I'm not sure this is the right way to handle this issue.
> The catch-up loop can be dropped and the automaton can loop over itself to
> reschedule. Doing that as the attached fixes this issue and also makes
> progress reporting work proprely in more cases, and reduces the number of
> lines of code. I did not add a test case because time sensitive tests have
> been removed (which is too bad, IMHO).
I agree with your way to fix. However, the progress reporting didn't work
because we cannot return from advanceConnectionState to threadRun and just
break the loop.
+ /* otherwise loop over PREPARE_THROTTLE */
I attached the fixed patch that uses return instead of break, and I confirmed
that this made the progress reporting work property.
Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>
|Next Message||David Rowley||2021-06-14 02:28:50||Re: An out-of-date comment in nodeIndexonlyscan.c|
|Previous Messageemail@example.com||2021-06-14 02:04:31||RE: Transactions involving multiple postgres foreign servers, take 2|