| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Incorrect GUC descriptions in docs and postgresql.conf.sample |
| Date: | 2021-05-26 01:43:14 |
| Message-ID: | 20210526014314.GH3676@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Your patch adds documentation about GUCs that can only be set at server
start/config/commandline.
But it's not true for any of these, which are all HUP/SUSET.
Please double check your logic :)
src/backend/utils/misc/guc.c: {"autovacuum_work_mem", PGC_SIGHUP, RESOURCES_MEM,
src/backend/utils/misc/guc.c: {"remove_temp_files_after_crash", PGC_SIGHUP, ERROR_HANDLING_OPTIONS,
src/backend/utils/misc/guc.c: {"restart_after_crash", PGC_SIGHUP, ERROR_HANDLING_OPTIONS,
src/backend/utils/misc/guc.c: {"log_lock_waits", PGC_SUSET, LOGGING_WHAT,
src/backend/utils/misc/guc.c: {"autovacuum_work_mem", PGC_SIGHUP, RESOURCES_MEM,
src/backend/utils/misc/guc.c: {"ssl_max_protocol_version", PGC_SIGHUP, CONN_AUTH_SSL,
src/backend/utils/misc/guc.c: {"ssl_min_protocol_version", PGC_SIGHUP, CONN_AUTH_SSL,
--
Justin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2021-05-26 01:51:31 | Re: storing an explicit nonce |
| Previous Message | Stephen Frost | 2021-05-26 01:42:48 | Re: storing an explicit nonce |