Re: Implementing Incremental View Maintenance

From: Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>
To: Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Andy Fan <zhihui(dot)fan1213(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Subject: Re: Implementing Incremental View Maintenance
Date: 2021-05-17 04:36:46
Message-ID: 20210517133646.04c3d9ed232af22c0f290ebc@sraoss.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 7 May 2021 14:14:16 +0900
Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp> wrote:

> On Mon, 26 Apr 2021 16:03:48 +0900
> Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp> wrote:
>
> > On Mon, 26 Apr 2021 15:46:21 +0900
> > Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp> wrote:
> >
> > > On Tue, 20 Apr 2021 09:51:34 +0900
> > > Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp> wrote:
> > >
> > > > On Mon, 19 Apr 2021 17:40:31 -0400
> > > > Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > > >
> > > > > Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> > > > > > This patch (v22c) just crashed for me with an assertion failure on
> > > > > > Fedora 31. Here's the stack trace:
> > > > >
> > > > > > #2  0x000000000094a54a in ExceptionalCondition
> > > > > > (conditionName=conditionName(at)entry=0xa91dae "queryDesc->sourceText !=
> > > > > > NULL", errorType=errorType(at)entry=0x99b468 "FailedAssertion",
> > > > > > fileName=fileName(at)entry=0xa91468
> > > > > > "/home/andrew/pgl/pg_head/src/backend/executor/execMain.c",
> > > > > > lineNumber=lineNumber(at)entry=199) at
> > > > > > /home/andrew/pgl/pg_head/src/backend/utils/error/assert.c:69
> > > > >
> > > > > That assert just got added a few days ago, so that's why the patch
> > > > > seemed OK before.
> > > >
> > > > Thank you for letting me know. I'll fix it.
> > >
> > > Attached is the fixed patch.
> > >
> > > queryDesc->sourceText cannot be NULL after commit 1111b2668d8,
> > > so now we pass an empty string "" for refresh_matview_datafill() instead NULL
> > > when maintaining views incrementally.
> >
> > I am sorry, I forgot to include a fix for 8aba9322511.
> > Attached is the fixed version.
>
> Attached is the rebased patch (for 6b8d29419d).

I attached a rebased patch.

--
Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>

Attachment Content-Type Size
IVM_patches_v22g.tar.gz application/gzip 83.2 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2021-05-17 04:39:50 Re: Race condition in recovery?
Previous Message Michael Paquier 2021-05-17 04:35:15 Re: Addition of authenticated ID to pg_stat_activity