Re: Implementing Incremental View Maintenance

On Tue, 20 Apr 2021 09:51:34 +0900
Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp> wrote:

> On Mon, 19 Apr 2021 17:40:31 -0400
> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> > Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> > > This patch (v22c) just crashed for me with an assertion failure on
> > > Fedora 31. Here's the stack trace:
> >
> > > #2  0x000000000094a54a in ExceptionalCondition
> > > (conditionName=conditionName(at)entry=0xa91dae "queryDesc->sourceText !=
> > > NULL", errorType=errorType(at)entry=0x99b468 "FailedAssertion",
> > > fileName=fileName(at)entry=0xa91468
> > > "/home/andrew/pgl/pg_head/src/backend/executor/execMain.c",
> > > lineNumber=lineNumber(at)entry=199) at
> > > /home/andrew/pgl/pg_head/src/backend/utils/error/assert.c:69
> >
> > That assert just got added a few days ago, so that's why the patch
> > seemed OK before.
>
> Thank you for letting me know. I'll fix it.

Attached is the fixed patch.

queryDesc->sourceText cannot be NULL after commit 1111b2668d8,
so now we pass an empty string "" for refresh_matview_datafill() instead NULL
when maintaining views incrementally.

Regards,
Yugo Nagata

--
Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>