| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Subject: | progress reporting for partitioned REINDEX |
| Date: | 2021-02-16 06:42:14 |
| Message-ID: | 20210216064214.GI28165@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
It looks like we missed this in a6642b3ae.
I think it's an odd behavior of pg_stat_progress_create_index to simultaneously
show the global progress as well as the progress for the current partition ...
It seems like for partitioned reindex, reindex_index() should set the AM, which
is used in the view:
src/backend/catalog/system_views.sql- WHEN 2 THEN 'building index' ||
src/backend/catalog/system_views.sql: COALESCE((': ' || pg_indexam_progress_phasename(S.param9::oid, S.param11)),
Maybe it needs a new flag, like:
params->options & REINDEXOPT_REPORT_PROGRESS_AM
I don't understand why e66bcfb4c added multiple calls to
pgstat_progress_start_command().
--
Justin
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-WIP-progress-reporting-for-CREATE-INDEX-on-partition.patch | text/x-diff | 10.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-02-16 06:50:31 | Re: ERROR: invalid spinlock number: 0 |
| Previous Message | Craig Ringer | 2021-02-16 06:29:30 | libpq PQresultErrorMessage vs PQerrorMessage API issue |