Re: LogwrtResult contended spinlock

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Jaime Casanova <jaime(dot)casanova(at)2ndQuadrant(dot)com>
Subject: Re: LogwrtResult contended spinlock
Date: 2021-01-30 01:47:56
Message-ID: 20210130014756.GA9923@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

So I tried this, but -- perhaps not suprisingly -- I can't get it to
work properly; the synchronization fails. I suspect I need some
barriers, but I tried adding a few (probably some that are not really
necessary) and that didn't have the expected effect. Strangely, all
tests work for me, but the pg_upgrade one in particular fails.

(The attached is of course POC quality at best.)

I'll have another look next week.

--
Álvaro Herrera 39°49'30"S 73°17'W

Attachment Content-Type Size
v2-0001-add-pg_atomic_monotonic_advance_u64.patch text/x-diff 1.2 KB
v2-0002-atomics-in-xlog.c.patch text/x-diff 11.9 KB
v2-0003-add-barriers.patch text/x-diff 3.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-01-30 01:53:49 Re: Should we make Bitmapsets a kind of Node?
Previous Message Michael Paquier 2021-01-30 01:27:22 Re: Support for NSS as a libpq TLS backend