Re: Key management with tests

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Tom Kincaid <tomjohnkincaid(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net>, Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>
Subject: Re: Key management with tests
Date: 2021-01-26 16:15:48
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Mon, Jan 25, 2021 at 10:27:18PM -0500, Bruce Momjian wrote:
> On Mon, Jan 25, 2021 at 07:09:44PM -0500, Bruce Momjian wrote:
> > > May I suggest to use "git format-patch" to produce the patch files? When
> > > working with a series like this, trying to do patch handling manually
> > > like you seem to be doing, is much more time-consuming and error prone.
> > > For example, with a branch containing individual commits, you could use
> > > git rebase -i origin/master -x "make install check-world"
> > > or similar, so that each commit is built and tested individually.
> >
> > I used "git format-patch". Are you asking for seven commits that then
> > generate seven files via one format-patch run? Or is the primary issue
> > that you want compile testing for each patch?
> The attached patch meets both criteria. I also clarified the README on
> how initdb calls those functions.

This version fixes OpenSSL detection and improves docs for initdb

Bruce Momjian <bruce(at)momjian(dot)us>

The usefulness of a cup is in its emptiness, Bruce Lee

Attachment Content-Type Size
key.diff.gz application/gzip 124.7 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Surafel Temesgen 2021-01-26 16:29:11 Re: FETCH FIRST clause PERCENT option
Previous Message Dave Cramer 2021-01-26 16:09:12 Re: Error on failed COMMIT