Re: Is it useful to record whether plans are generic or custom?

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: torikoshia(at)oss(dot)nttdata(dot)com
Cc: pgsql-hackers(at)postgresql(dot)org, masao(dot)fujii(at)oss(dot)nttdata(dot)com, tatsuro(dot)yamada(dot)tf(at)nttcom(dot)co(dot)jp, pavel(dot)stehule(at)gmail(dot)com, legrand_legrand(at)hotmail(dot)com
Subject: Re: Is it useful to record whether plans are generic or custom?
Date: 2021-01-25 05:10:20
Message-ID: 20210125.141020.1672465005495895485.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Tue, 12 Jan 2021 20:36:58 +0900, torikoshia <torikoshia(at)oss(dot)nttdata(dot)com> wrote in
> I suppose it would be normal practice to store past results of
> pg_stat_statements for future comparisons.
> If this is the case, I think that if we only add the number of
> generic plan execution, it will give us a hint to notice the cause
> of performance degradation due to changes in the plan between
> generic and custom.

Agreed.

> Attached a patch that just adds a generic call counter to
> pg_stat_statements.
>
> Any thoughts?

Note that ActivePortal is the closest nested portal. So it gives the
wrong result for nested portals.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2021-01-25 05:23:01 Re: Is Recovery actually paused?
Previous Message Masahiko Sawada 2021-01-25 04:58:01 Re: About to add WAL write/fsync statistics to pg_stat_wal view