| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Alexey Kondratov <a(dot)kondratov(at)postgrespro(dot)ru>, Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Steve Singer <steve(at)ssinger(dot)info>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Robert Haas <robertmhaas(at)gmail(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Jose Luis Tallon <jltallon(at)adv-solutions(dot)net> |
| Subject: | Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on the fly |
| Date: | 2021-01-18 08:37:57 |
| Message-ID: | 20210118083757.GG8560@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jan 18, 2021 at 02:18:44PM +0900, Michael Paquier wrote:
> On Sat, Dec 12, 2020 at 01:45:26PM -0600, Justin Pryzby wrote:
> > It's a lot like what I wrote as [PATCH v31 1/5] ExecReindex and ReindexParams
> > In my v31 patch, I moved ReindexOptions to a private structure in indexcmds.c,
> > with an "int options" bitmask which is passed to reindex_index() et al. Your
> > patch keeps/puts ReindexOptions index.h, so it also applies to reindex_index,
> > which I think is good.
>
> a3dc926 is an equivalent of 0001~0003 merged together. 0008 had
> better be submitted into a separate thread if there is value to it.
> 0004~0007 are the pieces remaining. Could it be possible to rebase
> things on HEAD and put the tablespace bits into the structures
> {Vacuum,Reindex,Cluster}Params?
Attached. I will re-review these myself tomorrow.
--
Justin
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Allow-REINDEX-to-change-tablespace.patch | text/x-diff | 24.6 KB |
| 0002-Refactor-and-reuse-set_rel_tablespace.patch | text/x-diff | 5.6 KB |
| 0003-Allow-CLUSTER-and-VACUUM-FULL-to-change-tablespace.patch | text/x-diff | 22.7 KB |
| 0004-Implement-vacuum-full-cluster-INDEX_TABLESPACE-table.patch | text/x-diff | 16.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joel Jacobson | 2021-01-18 08:41:17 | Re: evtfoid and evtowner missing in findoidjoins/README |
| Previous Message | tsunakawa.takay@fujitsu.com | 2021-01-18 08:37:26 | RE: Determine parallel-safety of partition relations for Inserts |