| From: | Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Hamid Akhtar <hamid(dot)akhtar(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: {CREATE INDEX, REINDEX} CONCURRENTLY improvements |
| Date: | 2021-01-12 20:21:29 |
| Message-ID: | 20210112202129.GA7219@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021-Jan-12, Álvaro Herrera wrote:
> > For the 0001 patch, since ReindexIndexInfo is used only within
> > ReindexRelationConcurrently() I think it’s a function-local structure
> > type. So we can declare it within the function. What do you think?
>
> That's a good idea. Pushed with that change, thanks.
Here's the other patch, with comments fixed per reviews, and rebased to
account for the scope change.
--
Álvaro Herrera Valdivia, Chile
Tulio: oh, para qué servirá este boton, Juan Carlos?
Policarpo: No, aléjense, no toquen la consola!
Juan Carlos: Lo apretaré una y otra vez.
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-set-PROC_IN_SAFE_IC-during-REINDEX-CONCURRENTLY.patch | text/x-diff | 6.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2021-01-12 20:38:38 | outdated references to replication timeout |
| Previous Message | Álvaro Herrera | 2021-01-12 20:10:28 | Re: {CREATE INDEX, REINDEX} CONCURRENTLY improvements |