| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net>, Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com> |
| Subject: | Re: Key management with tests |
| Date: | 2021-01-12 17:04:09 |
| Message-ID: | 20210112170409.GN4320@momjian.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Jan 10, 2021 at 09:51:16AM -0500, Bruce Momjian wrote:
> On Sun, Jan 10, 2021 at 06:04:12PM +1300, Thomas Munro wrote:
> > On Sun, Jan 10, 2021 at 3:45 PM Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > > Does anyone know why the cfbot applied the patch listed second first
> > > here?
> > >
> > > http://cfbot.cputube.org/patch_31_2925.log
> > >
> > > Specifically, it applied hex..key.diff.gz before hex.diff.gz. I assumed
> > > it would apply attachments in the order they appear in the email.
> >
> > It sorts the filenames (in this case after decompressing step removes
> > the .gz endings). That works pretty well for the patches that "git
> > format-patch" spits out, but it's a bit hit and miss with cases like
> > yours.
>
> OK, here they are with numeric prefixes. It was actually tricky to
> figure out how to create a squashed format-patch based on another branch.
Here is an updated version built on top of Michael Paquier's patch
posted here:
https://www.postgresql.org/message-id/X/0IChOPHd+aYC1w(at)paquier(dot)xyz
and included as my first attachment. This will give Michael's patch
cfbot testing too since the second attachment calls many of the first
attachment's functions.
--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
| Attachment | Content-Type | Size |
|---|---|---|
| 1-hex.diff.gz | application/gzip | 5.6 KB |
| 2-key_over_1-hex.diff.gz | application/gzip | 120.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2021-01-12 17:15:59 | Re: pg_upgrade test for binary compatibility of core data types |
| Previous Message | Andrey Borodin | 2021-01-12 16:43:28 | Re: libpq compression |