| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, buschmann(at)nidsa(dot)net, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pg_upgrade test for binary compatibility of core data types |
| Date: | 2020-12-16 17:22:23 |
| Message-ID: | 20201216172222.GS30237@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Sun, Dec 06, 2020 at 12:02:48PM -0600, Justin Pryzby wrote:
> I meant to notice if the binary format is accidentally changed again, which was
> what happened here:
> 7c15cef86 Base information_schema.sql_identifier domain on name, not varchar.
>
> I added a table to the regression tests so it's processed by pg_upgrade tests,
> run like:
>
> | time make -C src/bin/pg_upgrade check oldsrc=`pwd`/11 oldbindir=`pwd`/11/tmp_install/usr/local/pgsql/bin
Per cfbot, this avoids testing ::xml (support for which may not be enabled)
And also now tests oid types.
I think the per-version hacks should be grouped by logical change, rather than
by version. Which I've started doing here.
--
Justin
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-WIP-pg_upgrade-test.sh-changes-needed-to-allow-te.patch | text/x-diff | 5.2 KB |
| v2-0002-pg_upgrade-test-to-exercise-binary-compatibility.patch | text/x-diff | 5.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Devrim Gündüz | 2020-12-16 23:22:54 | Re: BUG #16761: BUG Cannot install last pg_activity. The package not signed |
| Previous Message | Bertrand Guillaumin | 2020-12-16 15:27:19 | Re: BUG #16759: Estimation of the planner is wrong for hash join |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alastair Turner | 2020-12-16 18:07:26 | Re: Proposed patch for key managment |
| Previous Message | Fujii Masao | 2020-12-16 17:15:00 | Re: Deadlock between backend and recovery may not be detected |