Re: pg_ls_tmpdir to show directories and shared filesets (and pg_ls_*)

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, David Steele <david(at)pgmasters(dot)net>, pgsql-hackers(at)postgresql(dot)org, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Subject: Re: pg_ls_tmpdir to show directories and shared filesets (and pg_ls_*)
Date: 2020-12-09 16:37:43
Message-ID: 20201209163742.GS24052@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Dec 04, 2020 at 12:23:23PM -0500, Tom Lane wrote:
> Justin Pryzby <pryzby(at)telsasoft(dot)com> writes:
> [ v24-0001-Document-historic-behavior-of-links-to-directori.patch ]
>
> The cfbot is unhappy with one of the test cases you added:

> Maybe it could be salvaged by reversing the sense of the WHERE condition
> so that instead of trying to blacklist stuff, you whitelist just a small
> number of files that should certainly be there.

Yes, I had noticed this one.

--
Justin

Attachment Content-Type Size
v25-0001-Document-historic-behavior-of-links-to-directori.patch text/x-diff 1.1 KB
v25-0002-pg_stat_file-and-pg_ls_dir_-to-use-lstat.patch text/x-diff 2.3 KB
v25-0003-Add-tests-on-pg_ls_dir-before-changing-it.patch text/x-diff 2.3 KB
v25-0004-Add-pg_ls_dir_metadata-to-list-a-dir-with-file-m.patch text/x-diff 19.0 KB
v25-0005-pg_ls_tmpdir-to-show-directories-and-isdir-argum.patch text/x-diff 6.7 KB
v25-0006-pg_ls_-dir-to-show-directories-and-isdir-column.patch text/x-diff 9.1 KB
v25-0007-pg_ls_logdir-to-ignore-error-if-initial-top-dir-.patch text/x-diff 3.1 KB
v25-0008-pg_ls_-dir-to-return-all-the-metadata-from-pg_st.patch text/x-diff 17.6 KB
v25-0009-pg_ls_-pg_stat_file-to-show-file-type.patch text/x-diff 21.5 KB
v25-0010-Preserve-pg_stat_file-isdir.patch text/x-diff 4.5 KB
v25-0011-Add-recursion-option-in-pg_ls_dir_files.patch text/x-diff 16.3 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-12-09 17:49:48 Re: [HACKERS] [PATCH] Generic type subscripting
Previous Message David G. Johnston 2020-12-09 15:40:21 Insert Documentation - Returning Clause and Order