| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, James Coleman <jtc331(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: "as quickly as possible" (was: remove spurious CREATE INDEX CONCURRENTLY wait) |
| Date: | 2020-11-23 20:31:24 |
| Message-ID: | 20201123203124.GA8215@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-Nov-19, Michael Paquier wrote:
> On Thu, Nov 19, 2020 at 12:13:44PM +0900, Michael Paquier wrote:
> > That still looks useful for debugging, so DEBUG1 sounds fine to me.
>
> By the way, it strikes me that you could just do nothing as long as
> (log_min_messages > DEBUG1), so you could encapsulate most of the
> logic that plays with the lock tag using that.
Good idea, done.
I also noticed that if we're going to accept a race (which BTW already
exists) we may as well simplify the code about it.
I think the attached is the final form of this.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Don-t-hold-ProcArrayLock-longer-than-needed-in-rare-.patch | text/x-diff | 4.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2020-11-23 20:36:55 | Re: Keep elog(ERROR) and ereport(ERROR) calls in the cold path |
| Previous Message | Anastasia Lubennikova | 2020-11-23 20:31:20 | Re: DROP relation IF EXISTS Docs and Tests - Bug Fix |