Re: WIP: BRIN multi-range indexes

From: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
To: Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: WIP: BRIN multi-range indexes
Date: 2020-11-02 23:25:45
Message-ID: 20201102232545.zw4xir577gq55ogj@development
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Mon, Nov 02, 2020 at 06:05:27PM +0000, Anastasia Lubennikova wrote:
>Status update for a commitfest entry.
>According to cfbot the patch no longer compiles. Tomas, can you send
>an update, please?

Yep, here's an updated patch series. It got broken by f90149e6285aa
which disallowed OID macros in pg_type, but fixing it was simple.

I've also included the patch adopting the one-hash bloom, as implemented
by John Naylor. I didn't have time to do any testing / evaluation yet,
so I've kept it as a separate part - ultimately we should either merge
it into the other bloom patch or discard it.

>I also see that a few last messages mention a data corruption bug.
>Sounds pretty serious. Alvaro, have you had a chance to look at it? I
>don't see anything committed yet, nor any active discussion in other

Yeah, I'm not aware of any fix addressing this - my understanding was
Alvaro plans to handle that, but amybe I misinterpreted his response.
Anyway, I think the fix is simple - we need to de-TOAST the data while
adding the data to index, and we need to consider what to do with
existing possibly-broken indexes.


Tomas Vondra
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
0001-Pass-all-scan-keys-to-BRIN-consistent-funct-20201103.patch text/plain 23.5 KB
0002-Move-IS-NOT-NULL-handling-from-BRIN-support-20201103.patch text/plain 23.3 KB
0003-optimize-allocations-20201103.patch text/plain 3.9 KB
0004-BRIN-bloom-indexes-20201103.patch text/plain 138.7 KB
0005-use-one-hash-bloom-variant-20201103.patch text/plain 8.5 KB
0006-BRIN-minmax-multi-indexes-20201103.patch text/plain 217.2 KB
0007-Ignore-correlation-for-new-BRIN-opclasses-20201103.patch text/plain 4.1 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2020-11-02 23:29:54 Re: Collation versioning
Previous Message Tom Lane 2020-11-02 22:50:08 Re: Since '2001-09-09 01:46:40'::timestamp microseconds are lost when extracting epoch