Re: bulk typos

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Cc: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>, Surafel Temesgen <surafel3000(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>
Subject: Re: bulk typos
Date: 2020-10-25 19:48:49
Message-ID: 20201025194849.GM9241@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Mar 31, 2018 at 05:56:40AM -0500, Justin Pryzby wrote:
> I needed another distraction so bulk-checked for typos, limited to comments in
> *.[ch].
>
> I'm not passionate about this, but it serves the purpose of reducing the
> overhead of fixing them individually.

I happened across this old patch, so ran this again to find new typos.

There's a few that I don't know how best to fix.

Heikki, do you remember what this means ?
+++ b/src/backend/catalog/storage.c
+ * NOTE: the list is kept in TopMemoryContext to be sure it won't disappear
+ * unbetimes. It'd probably be OK to keep it in TopTransactionContext,
+ * but I'm being paranoid.

Pavel, I can't understand this one.
I guess s/producement/producing/ is too simple of a fix.
Please check my proposed language.
+XmlTableFetchRow(TableFuncScanState *state)
+ * XmlTable returns table - set of composite values. The error context, is
+ * used for producement more values, between two calls, there can be
+ * created and used another libxml2 error context. ...

Surafel, this typo existed twice in the original commit (357889eb1).
One instance was removed by Tom in 35cb574aa. Should we simply fix the typo,
or borrow Julien/Tom's lanuage?
+ * Tuple at limit is needed for comparation in subsequent
+ * execution to detect ties.

Attachment Content-Type Size
0001-bulk-typos.patch text/x-diff 12.2 KB
0002-s-rewinded-rewound.patch text/x-diff 1.6 KB
0003-comparison-but-see-also-language-changed-at-35cb574a.patch text/x-diff 853 bytes
0004-producement-fcec6caafa2346b6c9d3ad5065e417733bd63cd9.patch text/x-diff 1.4 KB
0005-unbetimes-maybe-untimely-3396000684b41e7e9467d1abc67.patch text/x-diff 887 bytes
0006-More-likely-to-be-less-likely.patch text/x-diff 1.1 KB

In response to

  • bulk typos at 2018-03-31 10:56:40 from Justin Pryzby

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2020-10-25 21:00:33 Re: bulk typos
Previous Message Anastasia Lubennikova 2020-10-25 18:01:01 Re: Commitfest manager 2020-11