Re: "unix_socket_directories" should be GUC_LIST_INPUT?

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Ian Lawrence Barwick <barwick(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: "unix_socket_directories" should be GUC_LIST_INPUT?
Date: 2020-10-23 03:12:38
Message-ID: 20201023031238.GA5180@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Oct 23, 2020 at 11:34:06AM +0900, Ian Lawrence Barwick wrote:
> Not that I've ever had to do this (or would want to do it on a production
> system), but this error message seems incorrect:
>
> postgres=# ALTER SYSTEM SET unix_socket_directories =
> '/tmp/sock1','/tmp/sock2';
> ERROR: SET unix_socket_directories takes only one argument
>
> Trivial patch attached.

I have never seen that case, but I think that you are right. Still,
that's not the end of it, see by yourself what the following command
generates with only your patch, which is fancy:
ALTER SYSTEM SET unix_socket_directories = '/tmp/sock1','/tmp/, sock2';

We need an extra GUC_LIST_QUOTE on top of what you are proposing.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message bucoo@sohu.com 2020-10-23 03:20:31 Re: Re: parallel distinct union and aggregate support patch
Previous Message Masahiko Sawada 2020-10-23 02:58:16 Re: Global snapshots