| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Daniel Verite <daniel(at)manitou-mail(dot)org> |
| Subject: | Re: speed up unicode decomposition and recomposition |
| Date: | 2020-10-22 04:34:18 |
| Message-ID: | 20201022043418.GI1475@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 21, 2020 at 07:35:12PM -0400, John Naylor wrote:
> There was a mistake in v3 with pgindent/exclude_file_patterns, fixed in v4.
Thanks for the updated version, that was fast. I have found a couple
of places that needed to be adjusted, like the comment at the top of
generate-unicode_norm_table.pl or some comments, an incorrect include
in the new headers and the indentation was not right in perl (we use
perltidy v20170521, see the README in src/tools/pgindent).
Except that, this looks good to me. Attached is the updated version
with all my tweaks, that I would like to commit. If there are any
comments, please feel free of course.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| unicode-derecomp-v5.patch | text/x-diff | 158.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-10-22 04:34:20 | Re: Mop-up around psql's \connect behavior |
| Previous Message | Greg Nancarrow | 2020-10-22 04:16:08 | Re: Parallel INSERT (INTO ... SELECT ...) |