Re: speed up unicode normalization quick check

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>
Cc: John Naylor <john(dot)naylor(at)enterprisedb(dot)com>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: speed up unicode normalization quick check
Date: 2020-10-12 06:27:44
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Mon, Oct 12, 2020 at 02:43:06PM +0900, Masahiko Sawada wrote:
> The following warning recently started to be shown in my
> environment(FreeBSD clang 8.0.1). Maybe it is relevant with this
> commit:
> unicode_norm.c:478:12: warning: implicit declaration of function
> 'htonl' is invalid in C99 [-Wimplicit-function-declaration]
> hashkey = htonl(ch);
> ^

Thanks, it is of course relevant to this commit. None of the
BSD animals complain here. So, while it would be tempting to have an
extra include with arpa/inet.h, I think that it would be better to
just use pg_hton32() in pg_bswap.h, as per the attached. Does that
take care of your problem?

Attachment Content-Type Size
htonl-warning.patch text/x-diff 661 bytes

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2020-10-12 06:36:45 Re: Parallel INSERT (INTO ... SELECT ...)
Previous Message Masahiko Sawada 2020-10-12 06:22:14 Re: Resetting spilled txn statistics in pg_stat_replication