Re: Wrong statistics for size of XLOG_SWITCH during pg_waldump.

From: "movead(dot)li(at)highgo(dot)ca" <movead(dot)li(at)highgo(dot)ca>
To: Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, ahsan(dot)hadi <ahsan(dot)hadi(at)highgo(dot)ca>
Subject: Re: Wrong statistics for size of XLOG_SWITCH during pg_waldump.
Date: 2020-10-10 01:50:02
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

>I think that the length of the XLOG_SWITCH record is no other than 24
>bytes. Just adding the padding? garbage bytes to that length doesn't
>seem the right thing to me.
>If we want pg_waldump to show that length somewhere, it could be shown
>at the end of that record explicitly:
>rmgr: XLOG len (rec/tot): 24/16776848, tx: 0, lsn: 0/02000148, prev 0/02000110, desc: SWITCH, trailing-bytes: 16776944

Thanks, I think it's good idea, and new patch attached.

Here's the lookes:
rmgr: XLOG len (rec/tot): 24/ 24, tx: 0, lsn: 0/030000D8, prev 0/03000060, desc: SWITCH, trailing-bytes: 16776936

Highgo Software (Canada/China/Pakistan)
EMAIL: mailto:movead(dot)li(at)highgo(dot)ca

Attachment Content-Type Size
fix_waldump_size_for_wal_switch_v2.patch application/octet-stream 3.6 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Hou, Zhijie 2020-10-10 02:44:49 Use list_delete_xxxcell O(1) instead of list_delete_ptr O(N) in some places
Previous Message Ranier Vilela 2020-10-10 01:37:01 Re: Possible NULL dereferencing null pointer (src/backend/executor/nodeIncrementalSort.c)