Wrong statistics for size of XLOG_SWITCH during pg_waldump.

From: "movead(dot)li(at)highgo(dot)ca" <movead(dot)li(at)highgo(dot)ca>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Cc: ahsan(dot)hadi <ahsan(dot)hadi(at)highgo(dot)ca>
Subject: Wrong statistics for size of XLOG_SWITCH during pg_waldump.
Date: 2020-10-09 05:41:25
Message-ID: 2020100913412132258847@highgo.ca
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hello hackers,

We know that pg_waldump can statistics size for every kind of records. When I use
the feature I find it misses some size for XLOG_SWITCH records. When a user does
a pg_wal_switch(), then postgres will discard the remaining size in the current wal
segment, and the pg_waldump tool misses the discard size.

I think it will be better if pg_waldump can show the matter, so I make a patch
which regards the discard size as a part of XLOG_SWITCH record, it works if we
want to display the detail of wal records or the statistics, and patch attached.

What's your opinion?

Highgo Software (Canada/China/Pakistan)
URL : www.highgo.ca
EMAIL: mailto:movead(dot)li(at)highgo(dot)ca

Attachment Content-Type Size
fix_waldump_size_for_wal_switch.patch application/octet-stream 3.3 KB


Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Westermann (DWE) 2020-10-09 05:44:57 Re: Wrong example in the bloom documentation
Previous Message Amit Kapila 2020-10-09 05:31:23 Re: Parallel copy