| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Spurious "apparent wraparound" via SimpleLruTruncate() rounding |
| Date: | 2020-09-30 07:14:26 |
| Message-ID: | 20200930071426.GA1154112@rfd.leadboat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Sep 30, 2020 at 03:06:40PM +0900, Michael Paquier wrote:
> On Sun, Sep 06, 2020 at 08:14:21PM -0700, Noah Misch wrote:
> > http://cfbot.cputube.org/patch_29_2026.log applies the two patches in the
> > wrong order. For this CF entry, ignore it.
>
> OK, thanks. This is a bug fix, so I have moved that to the next CF
> for now. Noah, would you prefer more reviews or are you confident
> enough to move on with this issue?
The former. I plan to wait until a review puts this in Ready for Committer.
I'd be content if someone reviews the slru-truncate-modulo patch and disclaims
knowledge of the slru-truncate-insurance patch; I would then abandon the
latter patch. I'm not fond of how the latter turned out, particularly the
unintended consequence in TruncateMultiXact(). (See the commit message and/or
the edit to the comment in TruncateMultiXact().) The subtle interaction with
SerialAdd() is not great, either.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2020-09-30 07:15:43 | Re: Since '2001-09-09 01:46:40'::timestamp microseconds are lost when extracting epoch |
| Previous Message | Michael Paquier | 2020-09-30 07:11:55 | Re: track_planning causing performance regression |