Re: tab completion of IMPORT FOREIGN SCHEMA

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: tab completion of IMPORT FOREIGN SCHEMA
Date: 2020-09-15 05:56:40
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Mon, Aug 17, 2020 at 02:15:34PM +0900, Michael Paquier wrote:
> Sounds fine to me as well. The LIMIT TO and EXCEPT clauses are
> optional, so using TailMatches() looks fine.
> + else if (TailMatches("FROM", "SERVER", MatchAny, "INTO", MatchAny))
> Shouldn't you complete with "OPTIONS (" here?
> It would be good to complete with "FROM SERVER" after specifying
> EXCEPT or LIMIT TO, you can just use "(*)" to include the list of
> tables in the list of elements checked.

I have complete the patch with those parts as per the attached. If
there are any objections or extra opinions, please feel free.

Attachment Content-Type Size
foreign_schema_tab_complete_v2.patch text/x-diff 972 bytes

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2020-09-15 06:44:47 Re: logtape.c stats don't account for unused "prefetched" block numbers
Previous Message Andres Freund 2020-09-15 05:44:00 Re: Allow ERROR from heap_prepare_freeze_tuple to be downgraded to WARNING