Range checks of pg_test_fsync --secs-per-test and pg_test_timing --duration

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Range checks of pg_test_fsync --secs-per-test and pg_test_timing --duration
Date: 2020-08-06 06:27:59
Message-ID: 20200806062759.GE16470@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi all,

As $subject says, pg_test_fsync and pg_test_timing don't really check
the range of option values specified. It is possible for example to
make pg_test_fsync run an infinite amount of time, and pg_test_timing
does not handle overflows with --duration at all.

These are far from being critical issues, but let's fix them at least
on HEAD. So, please see the attached, where I have also added some
basic TAP tests for both tools.

Thanks,
--
Michael

Attachment Content-Type Size
pgtest-fix-range.patch text/x-diff 4.8 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message kato-sho@fujitsu.com 2020-08-06 07:25:00 RE: Creating foreign key on partitioned table is too slow
Previous Message Ashutosh Sharma 2020-08-06 06:11:38 Re: recovering from "found xmin ... from before relfrozenxid ..."