PROC_IN_ANALYZE stillborn 13 years ago

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: James Coleman <jtc331(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, simon(at)2ndquadrant(dot)com
Subject: PROC_IN_ANALYZE stillborn 13 years ago
Date: 2020-08-05 23:55:49
Message-ID: 20200805235549.GA8118@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Back in the 8.3 cycle (2007) when the autovacuum launcher/worker split
was done, we annoyed people because it blocked DDL. That led to an
effort to cancel autovac automatically when that was detected, by Simon

I was fixated on only cancelling when it was ANALYZE, to avoid losing
any VACUUM work.
That turned into some flags for PGPROC to detect whether a process was
ANALYZE, and cancel only those.

However, I was outvoted, so we do not limit cancellation to analyze.
Patch and discussion:

... which means the flag I had added two days earlier has never been
used for anything. We've carried the flag forward to this day for
almost 13 years, dutifully turning it on and off ... but never checking
it anywhere.

I propose to remove it, as in the attached patch.

Álvaro Herrera
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
0001-Remove-PROC_IN_ANALYZE.patch text/x-diff 3.6 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2020-08-06 00:35:15 Re: Reg. Postgres 13
Previous Message Peter Geoghegan 2020-08-05 23:25:14 Re: Amcheck: do rightlink verification with lock coupling