Re: SSL TAP test fails due to default client certs.

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: michael(at)paquier(dot)xyz
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: SSL TAP test fails due to default client certs.
Date: 2020-08-04 08:41:12
Message-ID: 20200804.174112.626710092248052387.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Tue, 4 Aug 2020 14:43:58 +0900, Michael Paquier <michael(at)paquier(dot)xyz> wrote in
> On Tue, Aug 04, 2020 at 12:00:33PM +0900, Kyotaro Horiguchi wrote:
> > While poking at ssl code, I noticed that 002_scram.pl fails if
> > ~/.postgresql/root.crt exists. This has been fixed once but
> > d6e612f837 reintroduced one. The attached fixes that. Applies to
> > 14devel and 13.
>
> Indeed, applied. I can reproduce the failure easily, and bdd6e9b is
> the previous fix you are mentioning. It is the only test where we
> don't rely on an $common_connstr that sets sslcert and sslrootcert to
> an invalid value, so the rest looks fine.

Agreed. Thanks for committing!

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2020-08-04 09:06:16 Re: [PATCH v1] elog.c: Remove special case which avoided %*s format strings..
Previous Message Kyotaro Horiguchi 2020-08-04 08:37:08 Re: Is it worth accepting multiple CRLs?