| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: expose parallel leader in CSV and log_line_prefix |
| Date: | 2020-08-01 03:31:13 |
| Message-ID: | 20200801033113.GE20393@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 31, 2020 at 03:04:48PM -0500, Justin Pryzby wrote:
> On Tue, Jul 28, 2020 at 10:10:33AM +0900, Michael Paquier wrote:
> > Except for those nits, I have tested the patch and things behave as we
> > want (including padding and docs), so this looks good to me.
>
> Revised with your suggestions.
Uh, wrong patch. 2nd attempt.
Also, I was reminded by Tom's c410af098 about this comment:
* Further note: At least on some platforms, passing %*s rather than
* %s to appendStringInfo() is substantially slower, so many of the
* cases below avoid doing that unless non-zero padding is in fact
* specified.
It seems we can remove that hack and avoid its spiriling conditionals.
It's cleaner to make that 0001.
--
Justin
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-Remove-performance-hack-for-s-format-strings.patch | text/x-diff | 9.3 KB |
| v5-0002-Include-the-leader-PID-in-logfile.patch | text/x-diff | 4.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2020-08-01 04:24:54 | Re: Parallel copy |
| Previous Message | Bharath Rupireddy | 2020-08-01 03:13:32 | Can a background worker exist without shared memory access for EXEC_BACKEND cases? |