Re: Online checksums verification in the backend

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Subject: Re: Online checksums verification in the backend
Date: 2020-07-14 09:08:08
Message-ID: 20200714090808.GA20780@nol
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Jul 12, 2020 at 12:34:03PM -0500, Justin Pryzby wrote:
> Small language fixes in comments and user-facing docs.

Thanks a lot! I just fixed a small issue (see below), PFA updated v10.

>
> diff --git a/src/backend/storage/page/checksum.c b/src/backend/storage/page/checksum.c
> index eb2c919c34..17cd95ec95 100644
> --- a/src/backend/storage/page/checksum.c
> +++ b/src/backend/storage/page/checksum.c
> @@ -36,7 +36,7 @@
> * actual storage, you have to discard the operating system cache before
> * running those functions.
> *
> - * To avoid torn page and possible false positive when reading data, and
> + * To avoid torn pages and possible false positives when reading data, and to
> * keeping overhead as low as possible, the following heuristics are used:
> *

Changed for "to keep".

Attachment Content-Type Size
v10-0001-Add-a-pg_check_relation-function.patch text/plain 42.9 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Julien Rouhaud 2020-07-14 09:14:50 Re: Avoid useless retrieval of defaults and check constraints in pg_dump -a
Previous Message Magnus Hagander 2020-07-14 08:59:45 Re: recovering from "found xmin ... from before relfrozenxid ..."