| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Daniel Gustafsson <daniel(at)yesql(dot)se>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: expose parallel leader in CSV and log_line_prefix |
| Date: | 2020-07-10 16:11:15 |
| Message-ID: | 20200710161115.GK26220@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 10, 2020 at 05:13:26PM +0200, Julien Rouhaud wrote:
> There's a thinko in the padding handling. It should be dones whether MyProc
> and/or lockGroupLeader is NULL or not, and only if padding was asked, like it's
> done for case 'd' for instance.
>
> Also, the '%k' escape sounds a bit random. Is there any reason why we don't
> use any uppercase character for log_line_prefix? %P could be a better
> alternative, otherwise maybe %g, as GroupLeader/Gather?
Thanks for looking. %P is a good idea - it's consistent with ps and pkill and
probably other %commands. I also amended the docs.
--
Justin
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Include-the-leader-PID-in-logfile.patch | text/x-diff | 4.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-07-10 16:28:17 | Re: Stale external URL in doc? |
| Previous Message | Tom Lane | 2020-07-10 16:01:10 | Re: GSSENC'ed connection stalls while reconnection attempts. |