Re: pg_upgrade fails if vacuum_defer_cleanup_age > 0

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pg_upgrade fails if vacuum_defer_cleanup_age > 0
Date: 2020-06-13 12:46:36
Message-ID: 20200613124636.GA20551@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jun 10, 2020 at 04:07:05PM +0200, Laurenz Albe wrote:
> A customer's upgrade failed, and it took me a while to
> figure out that the problem was that they had set
> "vacuum_defer_cleanup_age=10000" on the new cluster.
>
> The consequence was that the "vacuumdb --freeze" that
> takes place before copying commit log files failed to
> freeze "pg_database".
> That caused later updates to the table to fail with
> "Could not open file "pg_xact/0000": No such file or directory."
>
> I think it would increase the robustness of pg_upgrade to
> force "vacuum_defer_cleanup_age" to 0 on the new cluster.

Wow, I can see setting "vacuum_defer_cleanup_age" to a non-zero value as
causing big problems for pg_upgrade, and being hard to diagnose. I will
apply this patch to all branches.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EnterpriseDB https://enterprisedb.com

The usefulness of a cup is in its emptiness, Bruce Lee

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-06-13 15:56:00 Re: Definitional issue: stddev_pop (and related) for 1 input
Previous Message Fujii Masao 2020-06-13 11:37:47 Re: Resetting spilled txn statistics in pg_stat_replication