Removal of currtid()/currtid2() and some table AM cleanup

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: Hiroshi Saito <hiroshi(at)winpg(dot)jp>, "Inoue, Hiroshi" <h-inoue(at)dream(dot)email(dot)ne(dot)jp>
Subject: Removal of currtid()/currtid2() and some table AM cleanup
Date: 2020-06-03 02:14:48
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hi all,

I have been looking at the ODBC driver and the need for currtid() as
well as currtid2(), and as mentioned already in [1], matching with my
lookup of things, these are actually not needed by the driver as long
as we connect to a server newer than 8.2 able to support RETURNING. I
am adding in CC of this thread Saito-san and Inoue-san who are the
two main maintainers of the driver for comments. It is worth noting
that on its latest HEAD the ODBC driver requires libpq from at least

I would like to remove those two functions and the surrounding code
for v14, leading to some cleanup:
6 files changed, 326 deletions(-)

While on it, I have noticed that heap_get_latest_tid() is still
located within heapam.c, but we can just move it within

Attached are two patches to address both points. Comments are



Attachment Content-Type Size
0001-Remove-currtid-and-currtid2.patch text/x-diff 13.2 KB
0002-Move-heap_get_latest_tid-within-the-heap-AM-handler.patch text/x-diff 8.8 KB


Browse pgsql-hackers by date

  From Date Subject
Next Message David Fetter 2020-06-03 02:16:21 Re: Default gucs for EXPLAIN
Previous Message Michael Paquier 2020-06-03 02:02:59 Re: race condition when writing pg_control